Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crash Show Fragment During FileActivity Lifecycle Change #13037

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix Crash Show Fragment During FileActivity Lifecycle Change #13037

merged 1 commit into from
May 29, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented May 24, 2024 •
edited

  • Tests written, or not not needed

@alperozturk96
use commitAllowingStateLoss
56199b9 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 mentioned this pull request May 24, 2024
Closed
1 task
This was linked to issues May 24, 2024
App crash #12970
Closed
Crash while viewing (and downloading) media (in the background) #12760
Closed
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13037.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit cf52d8c into master May 29, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/crash-on-fragment-show-on-file-activity branch May 29, 2024 10:03
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom ZetaTom approved these changes

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

App crash Crash while viewing (and downloading) media (in the background)
3 participants
@alperozturk96 @ZetaTom @AndyScherzinger