Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "HasDiscountsApplied" product column #7188

Open
AndreiMaz opened this issue May 13, 2024 · 0 comments
Open

Drop "HasDiscountsApplied" product column #7188

AndreiMaz opened this issue May 13, 2024 · 0 comments
Assignees
@exileDev
Labels
refactoring / source code
Milestone
Version 4.80

Comments

@AndreiMaz
Copy link
Member

There's no need to keep "HasDiscountsApplied" column in the "Product" entity.

It was required for performance optimizarion when we used Entity Framework. Now we can cache values between HTTP requests. Hence we can remove this property. Just ensure that these discounts are properly cached between HTTP requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exileDev exileDev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.80
Development

No branches or pull requests
2 participants
@AndreiMaz @exileDev