Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice of Breaking Changes #1470

Open
fdschmidt93 opened this issue Nov 19, 2021 · 6 comments
Open

Notice of Breaking Changes #1470

fdschmidt93 opened this issue Nov 19, 2021 · 6 comments

Comments

@fdschmidt93
Copy link
Member

fdschmidt93 commented Nov 19, 2021

This pinned issue is supposed to announce breaking changes (and possibly other critical info) to users.

The idea is that we announce (potentially) breaking changes with sufficient time (ideally weeks) in advance. Therefore, it is recommended to subscribe to the issue as means to keep informed about breaking news.

Any member should feel free to edit the OP as they see fit.

@fdschmidt93 fdschmidt93 added enhancement Enhancement to performance, inner workings or existent features and removed enhancement Enhancement to performance, inner workings or existent features labels Nov 19, 2021
@fdschmidt93 fdschmidt93 pinned this issue Nov 19, 2021
@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Nov 19, 2021

The builtin.file_browser will be removed in 1 week (5th of January). A deprecation notice upon launch of builtin.file_browser will be merged a week ahead of removal. Associated PR: #1453

Users should then move to https://github.com/nvim-telescope/telescope-file-browser.nvim. This is part of the larger strategy to incrementally carve out built-in pickers to own repos. For more, please see #1228.

@nvim-telescope nvim-telescope locked as off-topic and limited conversation to collaborators Nov 19, 2021
@clason clason changed the title Notices Notice of Breaking Changes Nov 20, 2021
@Conni2461
Copy link
Member

As of December 10 (1 week from now) telescope will only support Neovim 0.6 or higher: #1549

If you can't upgrade to this version you have to pin the latest working version in your plugin manager, until you can upgrade.

@Conni2461
Copy link
Member

Conni2461 commented Dec 10, 2021

Move from vim.lsp.diagnostic to vim.diagnostic #1553

Because the newly added vim.diagnostic has no longer anything to do with lsp we also decided to rename our diagnostic functions:

  • Telescope lsp_document_diagnostics -> Telescope diagnostics bufnr=0
  • Telescope lsp_workspace_diagnostics -> Telescope diagnostics

For more informations see :help telescope.changelog-1553 and :help builtin.diagnostics

@Conni2461
Copy link
Member

Conni2461 commented Apr 20, 2022

We will bump the minimum required neovim version 0.7.0 stable for telescope this friday #1851

We will create a tag the working telescope version with neovim 0.6 with the following tag nvim-0.6 this should then work for 0.6.0 and 0.6.1.

After that neovim version bump we will merge fixes and usage of new features (lua autocmds) that the newest neovim release provides.

Soon after this version bump we will adopt a new release strategy. This release strategy is described by tj here #1772

For more information see :help telescope.changelog-1851 (changelog will appear after #1851 is merged)

@Conni2461
Copy link
Member

We decided to remove lsp_code_actions and lsp_range_code_actions from telescope, probably in the next two days. #1866

The reason for this is that code_actions is currently out of date duplicated code from neovim upstream and vim.lsp.buf.code_action vim.lsp.buf.range_code_action has more features and less bugs. The thing that makes the move from Telescope lsp_code_actions to vim.lsp.buf.code_action really compelling is vim.ui.select (which is used for code_actions) and allows users to override it with their own preferred UI.

We wrote a small repo some time ago that allows telescope to be this UI: https://github.com/nvim-telescope/telescope-ui-select.nvim and there is also this https://github.com/stevearc/dressing.nvim which has providers for a couple of different UIs.

For more information see :help telescope.changelog-1866

Conni2461 referenced this issue Apr 27, 2022
see :help telescope.changelog-1866 for more information
@Conni2461
Copy link
Member

#2529 was merged and it replaced plenary.filetype with vim.filetype.match.

for more information see :help telescope.changelog-2529

@Conni2461 Conni2461 unpinned this issue Oct 11, 2023
@Conni2461 Conni2461 pinned this issue Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants