Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Typos in the official document #1147

Open
1 task done
Galaxy-Husky opened this issue May 13, 2024 · 1 comment
Open
1 task done

[Feature] Typos in the official document #1147

Galaxy-Husky opened this issue May 13, 2024 · 1 comment
Assignees

Comments

@Galaxy-Husky
Copy link

Describe the feature

Hi,
I found some typos in the efficient evaluation of the official document.

In the following code snippet:

```python
from opencompass.runners import LocalRunner
from opencompass.tasks import OpenICLInferTask
infer = dict(
# ...
runner=dict(
type=LocalRunner,
max_num_workers=16, # Maximum number of processes to run in parallel
task=dict(type=OpenICLEvalTask), # Task to be run
)
)
```

line 97 task=dict(type=OpenICLEvalTask) should be task=dict(type=OpenICLInferTask).

And the following line 118 has the same typo:

```python
from opencompass.runners import SlurmRunner
from opencompass.tasks import OpenICLInferTask
infer = dict(
# ...
runner=dict(
type=SlurmRunner,
task=dict(type=OpenICLEvalTask), # Task to be run
max_num_workers=16, # Maximum concurrent evaluation task count
retry=2, # Retry count for failed tasks, can prevent accidental errors
),
)
```

Will you implement it?

  • I would like to implement this feature and create a PR!
@liushz
Copy link
Collaborator

liushz commented May 14, 2024

Thanks for pointing this typo, we will refine it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants