Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: publish to pypi.org using namespace package #1885

Open
tcztzy opened this issue May 1, 2024 · 6 comments
Open

infra: publish to pypi.org using namespace package #1885

tcztzy opened this issue May 1, 2024 · 6 comments
Labels
core core feature enhancement New feature or request help wanted Extra attention is needed

Comments

@tcztzy
Copy link

tcztzy commented May 1, 2024

Is your feature request related to a problem? Please describe.
Publish this project to Pypi.org using namespace package.

Describe the solution you'd like
Once it is publish as a namespace like open_webui, then third party developer can publish their package like open_webui.apps.<my_app>

Describe alternatives you've considered
No

Additional context
No

@tjbck tjbck changed the title Feat: publish to Pypi.org using namespace package infra: publish to pypi.org using namespace package May 4, 2024
@tjbck tjbck added help wanted Extra attention is needed enhancement New feature or request labels May 4, 2024
@tjbck
Copy link
Contributor

tjbck commented May 4, 2024

Github workflow PR welcome!

@tcztzy
Copy link
Author

tcztzy commented May 6, 2024

I can contribute but It will rename the top level backend directory to open-webui, would you accept such a big change? And we also need a Pypi organization account.

@tjbck
Copy link
Contributor

tjbck commented May 6, 2024

If we can rename the backend directory during our workflow that would be ideal.

@tcztzy
Copy link
Author

tcztzy commented May 6, 2024

it can be done without renaming the directory, but renaming the python imports is required in most cases. For example

from apps.ollama.main import app as ollama_app

should be refactored as

from open_webui.apps.ollama.main import app as ollama_app 

and

from utils.utils import get_admin_user

should be refactored as

from open_webui.utils.utils import get_admin_user

apps/utils/constants/config are very common module names and will conflict with other packages.

@tcztzy
Copy link
Author

tcztzy commented May 13, 2024

Maybe we should publish it firstly, use pipx will install package separated from other, therefore name conflict is not a big problem

@tjbck tjbck added the core core feature label May 14, 2024
@tjbck
Copy link
Contributor

tjbck commented May 14, 2024

I'll prioritise this in the near future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core core feature enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants