-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Console error in chapter editor page. #19816
Comments
This issue occurs on the 3.3.5 branch as well. |
@seanlip Hello! I believe I have resolved these console errors by changing where the values are set to be more similar to the way they were set when on the subTopic page. While doing so, I observed that the 'header text' and 'subheader text' values were not being displayed anywhere, despite being defined for the Mobile Screen due to the condition !WindowIsNarrow. Therefore, I removed the '!', added the condition to check if the title exists and corrected the display of those values on the frontend. Is this the desired outcome? 19816.Fixed.mp4 |
…et and fix their display on frontend
@Sepremo Sorry for the late reply. I think what we would need to know, is what the cause of the original error is. Can you explain it? (Otherwise we cannot be sure that your fix addresses the root cause of the error.) I'm also finding it hard to understand what exactly you changed and the reasoning behind it. Perhaps you could explain that in more detail? Thanks! |
Certainly! The error occurred when attempting to open the Chapter Editor in the Story Editor. It appears that the Upon further investigation, I noticed a similar scenario where opening a subTopic Editor tab from the Topic Editor page did not encounter this error. The disparity lies in how the
To address the issue, I relocated the updates for the Upon further examination, I observed that these values failed to display even when I resized the screen to simulate a mobile device. I discovered that the values were not visible when the
You're welcome! I'm sorry if I explained anything poorly. |
Thanks @Sepremo! This all sounds reasonable, feel free to create a PR. I'll assign you to the issue so that you can do that. Thanks! |
@seanlip |
…et and fix their display on frontend
Describe the bug
console error is seen in chapter editor page.
URL of the page where the issue is observed.
https://www.oppiatestserver.org/story_editor/wvGQpYllJzVf#/chapter_editor/node_1
Steps To Reproduce
visit the link provided in the url section.
Expected Behavior
no console error should be there.
Screenshots/Videos
What device are you using?
Desktop
Operating System
Windows
What browsers are you seeing the problem on?
Chrome
Browser version
Version 121.0.6167.161 (Official Build) (64-bit)
Additional context
No response
Tips for developers
Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).
Also, if this is your first issue, please make sure to follow https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#choosing-a-good-first-issue and https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up before claiming it. Thanks!
The text was updated successfully, but these errors were encountered: