Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ord list doesn't work in 0.17.1 #3493

Closed
gmart7t2 opened this issue Apr 9, 2024 · 2 comments · Fixed by #3762
Closed

ord list doesn't work in 0.17.1 #3493

gmart7t2 opened this issue Apr 9, 2024 · 2 comments · Fixed by #3762
Labels
bug

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Apr 9, 2024

The is_output_in_active_chain() function in index.rs is looking at the in_active_chain field of the raw transaction output, but it is always None.

That field is only set if getrawtransaction is passed a block hash, and it isn't.

This fixes it:

diff --git a/src/index.rs b/src/index.rs
index bec84d0a..42047131 100644
--- a/src/index.rs
+++ b/src/index.rs
@@ -1630,7 +1630,7 @@ impl Index {
       return Ok(false);
     };
 
-    if !info.in_active_chain.unwrap_or_default() {
+    if info.blockhash.is_none() {
       return Ok(false);
     }
@raphjaph
Copy link
Collaborator

Thanks for the report!

Could you open a PR for this?

@cryptoni9n
Copy link
Collaborator

Hi @gmart7t2 - does this issue persist in the latest version? If so, would you please open a PR for it? Thanks!

cryptoni9n added a commit to cryptoni9n/ord that referenced this issue May 16, 2024
@cryptoni9n
Update index.rs to fix ord list command
d37966c 
this is Greg's code to fix ordinals#3493 - I replicated the issue and verified that this fixed it on my local.
cryptoni9n added a commit to cryptoni9n/ord that referenced this issue May 16, 2024
@cryptoni9n
Update index.rs to fix ord list command
aca3963 
this is Greg's code to fix ordinals#3493 - I replicated the issue and verified that this fixed it on my local.
cryptoni9n added a commit to cryptoni9n/ord that referenced this issue May 16, 2024
@cryptoni9n
Update index.rs to fix ord list command
4e7bedb 
this is Greg's code to fix ordinals#3493 - I replicated the issue and verified that this fixed it on my local.
cryptoni9n added a commit to cryptoni9n/ord that referenced this issue May 16, 2024
@cryptoni9n
Update index.rs to fix ord list command
1a2ee8d 
this is Greg's code to fix ordinals#3493 - I replicated the issue and verified that this fixed it on my local.
@cryptoni9n cryptoni9n mentioned this issue May 16, 2024
Merged
@cryptoni9n cryptoni9n added the bug label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update index.rs to fix ord list command cryptoni9n/ord
3 participants
@raphjaph @gmart7t2 @cryptoni9n