Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shader lit #6

Open
Againstyou opened this issue Jan 20, 2022 · 4 comments
Open

Make shader lit #6

Againstyou opened this issue Jan 20, 2022 · 4 comments

Comments

@Againstyou
Copy link

Thanks for your work!
I testing your shader and it works great.
But in my enviroment i need some Reflections, so it would be nice making a lit version of the shader. Is that possible?
I wonder if it would even work for proper shadows but this could result in a black box instead of the actual cutout?

grafik

What do you think, is it possible to transform the shader to lit?

@otdavies
Copy link
Owner

otdavies commented Jan 22, 2022 via email

@otdavies
Copy link
Owner

Leaving this here for reference regarding the shadows: https://cyangamedev.wordpress.com/2020/06/05/urp-shader-code/10/
There is likely a way to use an alpha cutoff or the likes to make sure we get a pretty believable shadow. I'll create a version of the shader that is lit so that it will work with screen space / planar reflections hopefully.

@Againstyou
Copy link
Author

Againstyou commented Jan 28, 2022

Thank you for your reply!
That sounds great, especially because your shader is one which support HDRP which is really useful to implement a realistic and believable enviroment.
As i've seen your reference is about URP, do you think it will be possible for HDRP too?
Thanks for your great work!

@Againstyou
Copy link
Author

Againstyou commented Feb 1, 2022

https://github.com/RemyUnity/SG-HDRP-Lit

Maybe that helps. Its a ShaderGraph Version of the LitShader. Maybe its possible to adjust for Chromakey and keep the lighting stuff. But it looks a bit outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants