Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional roadblocks when trying to turn on video passthrough mode #3433

Open
gabek opened this issue Nov 20, 2023 · 3 comments
Open

Add additional roadblocks when trying to turn on video passthrough mode #3433

gabek opened this issue Nov 20, 2023 · 3 comments
Labels
admin Issues related to the Admin portion backlog Ideas that might be cool and can be looked into later.

Comments

@gabek
Copy link
Member

gabek commented Nov 20, 2023

Share your bug report, feature request, or comment.

I've noticed an uptick in the number of people who turn on video passthrough, acknowledge that it may cause issues for them, and then report that Owncast doesn't work. My first question is always "Is passthrough enabled?" and the answer is always "yes". So I tell them to turn it off.

image

It's clear nobody reads the disclaimer, so it would be helpful to make it a bit more inconvenient to enable the feature. Maybe the "Yes" button is disabled for a few seconds, to force the person to read it. Maybe the text should be scarier, explicitly stating that once they say "Yes" the stream may no longer be playable. Maybe the "No" button should be the default.

I'm up for any other suggestions, as well.

See #3431 for additional documentation-related changes to help with this problem.

@gabek gabek added the admin Issues related to the Admin portion label Nov 20, 2023
@rmens
Copy link

rmens commented Nov 20, 2023

Maybe remove it from the GUI and make it a CLI flag?

@aaronpk
Copy link
Contributor

aaronpk commented Nov 20, 2023

How about this:

  • On the viewer, show a red box around the video player and a big warning below that says passthrough mode is enabled
  • Provide a new toggle switch in the viewer to hide the warning

gabek added a commit that referenced this issue Nov 21, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this was a feature request that others have shown no interest in then it's likely to not get implemented due to lack of interest. If others also want to see this feature then now is the time to say something! Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@gabek gabek added backlog Ideas that might be cool and can be looked into later. and removed stale labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issues related to the Admin portion backlog Ideas that might be cool and can be looked into later.
Projects
None yet
Development

No branches or pull requests

3 participants