Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather questions sometimes blows up on certain city names #175

Open
mattlindsey opened this issue Jun 12, 2023 · 2 comments · May be fixed by #602
Open

Weather questions sometimes blows up on certain city names #175

mattlindsey opened this issue Jun 12, 2023 · 2 comments · May be fixed by #602

Comments

@mattlindsey
Copy link
Contributor

ChainOfThought agent usually provides a good city name to the Weather tool, but can blow up (or be tricked into blowing up) on city names.

First example works, second blows up on same city:

image
@andreibondarev
Copy link
Collaborator

I think this issue is either on the gem's or the actual API's end. "Boston, MA" is a completely valid way of formatting the location name. For example: If I type it in on weather.com -- I won't be getting an error.

@mattlindsey
Copy link
Contributor Author

mattlindsey commented Jun 15, 2023 •
edited

I think this is because there are two ways listed in the README for the gem to get weather for a city.
We are currently using the first one below. Using the second method may solve the problem, but it needs a little research.

Also note the weather gem uses Open Weather API 2.5 while the website lists only 3.0. There are tasks to update the gem.

data = client.current_weather(city: 'London')

client.current_city('New York', 'NY', 'US')

@mattlindsey mattlindsey mentioned this issue Jun 18, 2023
Closed
@mattlindsey mattlindsey mentioned this issue Mar 10, 2024
Open
@mattlindsey mattlindsey linked a pull request May 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@andreibondarev @mattlindsey