Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it just me, off by 1 stop? #1

Open
songcarver opened this issue May 3, 2017 · 1 comment
Open

Is it just me, off by 1 stop? #1

songcarver opened this issue May 3, 2017 · 1 comment

Comments

@songcarver
Copy link

Thanks so much for making this plugin. It's amazing more designers don't understand/have tools to use the LaB space. So much manual tuning!

Small thing here, perhaps just perception, but fading between a red and a blue, it feels like the stops are weighted a little heavy to the red side. However, if I move over the stops as though there was another stop to be inserted on the blue (left) side, it seems more balanced to my eye.

Any chance an off-by-1 error slipped in, resulting in slightly skewed gradient stops?

Hopefully attached image can make the perceived balance issue clear.

color comparison

@petterheterjag
Copy link
Owner

@songcarver Thanks for the kind words!

I've also noticed the gradients being weighted towards red. However, I'm not sure it's a bug. When I switch to use RGB for the interpolation, the gradient gets perfectly weighted. That should indicate that it's not an error in the color stop calculation.

My current belief is that this is a drawback of the Lab model, and how it treats certain colors. Gradients with red seems to be affected the most, while other color combinations seems to create more equally weighted gradients.

I'll look into this a bit more though, maybe something clever can be done to improve it. Thanks for creating the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants