Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: init metrics with constlabls #53380

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

metrics: init metrics with constlabls #53380

wants to merge 4 commits into from

Conversation

zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented May 20, 2024 •
edited

What problem does this PR solve?

Issue Number: close #53383

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zeminzhou
init metrics with constlabls
0264c39 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 20, 2024

Hi @zeminzhou. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeminzhou
get metrics labels from config
9a3b58f 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign asddongmen, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zeminzhou
make check
2c97d74 
Signed-off-by: zzm <zhouzemin@pingcap.com>
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 74.6611%. Comparing base (f5ac93e) to head (ae0b525).
Report is 45 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53380        +/-   ##
================================================
+ Coverage   72.6008%   74.6611%   +2.0602%     
================================================
  Files          1505       1505                
  Lines        429827     431037      +1210     
================================================
+ Hits         312058     321817      +9759     
+ Misses        98576      89304      -9272     
- Partials      19193      19916       +723
Flag Coverage Δ
integration 49.1290% <30.7692%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4368% <ø> (+9.0362%) ⬆️

ystaticy
ystaticy reviewed May 21, 2024
View reviewed changes
cmd/tidb-server/main.go
@@ -279,7 +279,7 @@ func main() {
os.Exit(0)
}
registerStores()
err := metricsutil.RegisterMetrics()
err := metricsutil.RegisterMetricsWithLabels(config.GetGlobalConfig().MetricsLabels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test case for labels!=nil

@zeminzhou
fix comment
ae0b525 
Signed-off-by: zzm <zhouzemin@pingcap.com>
@zeminzhou
Copy link
Contributor Author

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented May 21, 2024

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zeminzhou zeminzhou changed the title meitrcs: init metrics with constlabls metrics: init metrics with constlabls May 27, 2024
@zeminzhou
Copy link
Contributor Author

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented May 27, 2024

@zeminzhou: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 27, 2024

@zeminzhou: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test ae0b525 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ystaticy ystaticy ystaticy left review comments

Assignees
No one assigned
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add metrics labels from config
2 participants
@zeminzhou @ystaticy