Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some typo about Changefeed #11050

Merged
merged 2 commits into from
May 28, 2024
Merged

chore: fix some typo about Changefeed #11050

merged 2 commits into from
May 28, 2024

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented May 8, 2024 •
edited by asddongmen

What problem does this PR solve?

Issue Number: close #11049

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed contribution Indicates that the PR was contributed by an external member. labels May 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels May 8, 2024
@asddongmen
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 04:03:42.674044924 +0000 UTC m=+2144376.431180498: ☑️ agreed by asddongmen.
  • 2024-05-28 03:58:12.8025498 +0000 UTC m=+2748846.559685373: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.3101%. Comparing base (cf7055d) to head (233eea5).

Additional details and impacted files
Components Coverage Δ
cdc 61.4270% <50.0000%> (∅)
dm 51.1820% <ø> (-0.0283%) ⬇️
engine 63.4020% <ø> (-0.0071%) ⬇️
Flag Coverage Δ
unit 57.3101% <50.0000%> (+3.3912%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11050        +/-   ##
================================================
+ Coverage   53.9188%   57.3101%   +3.3912%     
================================================
  Files           403        857       +454     
  Lines         63781     127262     +63481     
================================================
+ Hits          34390      72934     +38544     
- Misses        26694      48929     +22235     
- Partials       2697       5399      +2702

@wk989898
Copy link
Contributor Author

/retest

1 similar comment
@wk989898
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 327b89a into pingcap:master May 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees
No one assigned
Labels
approved contribution Indicates that the PR was contributed by an external member. lgtm ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc: some typo about Changefeed
4 participants
@wk989898 @asddongmen @hongyunyan @CharlesCheung96