Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} #11122

Merged
merged 4 commits into from
May 21, 2024
Merged

dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} #11122

merged 4 commits into from
May 21, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 16, 2024 •
edited

What problem does this PR solve?

Issue Number: close #11121

What is changed and how it works?

When cherry-pick this PR to release branches, remember to pick the fix PR of pingcap/tidb#53357 to tidb as well

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@lance6716
*: remove usage of tidb-tools/pkg/{dbutil, utils}
d011fe8 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. labels May 16, 2024
@lance6716 lance6716 requested a review from asddongmen May 16, 2024 09:14
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
@lance6716 lance6716 changed the title dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} [WIP]dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} May 16, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 48.57143% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 57.5536%. Comparing base (1c7c9ae) to head (38b114d).
Report is 7 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.9779% <85.7142%> (+0.0018%) ⬆️
dm 51.2253% <43.0107%> (-0.0238%) ⬇️
engine 63.3808% <100.0000%> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.5536% <48.5714%> (-0.0128%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11122        +/-   ##
================================================
- Coverage   57.5663%   57.5536%   -0.0128%     
================================================
  Files           854        854                
  Lines        126006     126112       +106     
================================================
+ Hits          72537      72582        +45     
- Misses        48081      48143        +62     
+ Partials       5388       5387         -1

@lance6716
fix side effect of dbutil
6ee8257 
Signed-off-by: lance6716 <lance6716@gmail.com>
@3AceShowHand
Copy link
Contributor

/retest

@lance6716
upgrade tidb
7dd7360 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2024
@lance6716
try fix CI
38b114d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@3AceShowHand
Copy link
Contributor

/retest

@lance6716 lance6716 changed the title [WIP]dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} dep(*): remove usage of tidb-tools/pkg/{dbutil, utils} May 20, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 06:25:36.224849905 +0000 UTC m=+2066489.981985475: ☑️ agreed by 3AceShowHand.
  • 2024-05-21 01:37:15.220921769 +0000 UTC m=+2135588.978057342: ☑️ agreed by asddongmen.

@lance6716
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 21, 2024
@ti-chi-bot ti-chi-bot bot merged commit de06be9 into pingcap:master May 21, 2024
28 checks passed
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 21, 2024
@3AceShowHand
Copy link
Contributor

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11154.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 21, 2024
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#11122
5e66512 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 21, 2024
Closed
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-7.5 from head ti-chi-bot:cherry-pick-11122-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-11122-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 21, 2024
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#11122
1b0b889 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2024
@lance6716 @3AceShowHand
This is an automated cherry-pick of pingcap#11122
bc52a80 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@asddongmen asddongmen asddongmen approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove usage of remove usage of tidb-tools/pkg/{dbutil, utils}
4 participants
@lance6716 @3AceShowHand @ti-chi-bot @asddongmen