-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-fix: spo tenant recyclebinitem restore
#6057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far. I saw right now that we are introducing a breaking change. Let's avoid this at all costs.
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
src/m365/spo/commands/tenant/tenant-recyclebinitem-restore.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some minor things, it looks good to me!
} | ||
|
||
await logger.log(responseContent); | ||
// Here, we return a fixed response due to removing the '--wait' functionality as it is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, we are not doing this because we are removing --wait, but because we switched to a new endpoint that has no output.
})) { | ||
return "{\"HasTimedout\":false,\"IsComplete\":true,\"PollingInterval\":15000}"; | ||
} | ||
it(`restores deleted group site from a deleted team site`, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it(`restores deleted group site from a deleted team site`, async () => { | |
it(`restores deleted group from a deleted team site`, async () => { |
assert.strictEqual(postStub.lastCall.args[0].url, groupRestoreUrl); | ||
}); | ||
|
||
it('restores restores a deleted SharePoint site', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('restores restores a deleted SharePoint site', async () => { | |
it('restores a deleted SharePoint site without group', async () => { |
Merged manually, thank you for this fix! 👏 |
Closes #6021