You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Node based JavaScript console that is generated into
presto-main/src/main/resources/webapp/
seems mostly independent of the rest of the code base. Its build system is a hack that shells out from maven to download nodejs and use yarn. This doesn't integrate well into all CI systems because different tools than normal download code from locations other than the Maven repository system. This can be more or less painful depending on how firewalls and proxies are configured. Exactly what problems any given developer will have where depends on their local environment. (We already know this caused different problems for two different groups of developers when #22645 was merged.)
Assuming we can't rewrite this so it's all just Java+Maven, consider moving this into a separate module or repo. That is, ./mvnw clean install no longer builds any of this. It can have a completely separate build that might not even use Maven and instead go straight to nodejs and yarn.
The text was updated successfully, but these errors were encountered:
The Node based JavaScript console that is generated into
presto-main/src/main/resources/webapp/
seems mostly independent of the rest of the code base. Its build system is a hack that shells out from maven to download nodejs and use yarn. This doesn't integrate well into all CI systems because different tools than normal download code from locations other than the Maven repository system. This can be more or less painful depending on how firewalls and proxies are configured. Exactly what problems any given developer will have where depends on their local environment. (We already know this caused different problems for two different groups of developers when #22645 was merged.)
Assuming we can't rewrite this so it's all just Java+Maven, consider moving this into a separate module or repo. That is,
./mvnw clean install
no longer builds any of this. It can have a completely separate build that might not even use Maven and instead go straight to nodejs and yarn.The text was updated successfully, but these errors were encountered: