Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Feature to update the default prometheusrules, like CPUThrottlingHigh value #4513

Open
sambitr opened this issue May 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sambitr
Copy link

sambitr commented May 3, 2024

Is your feature request related to a problem ?

Hi There, we are using Kube-prometheus-stack Helm chart to create prometheus rules and all. During this process, CRD: prometheusrules.monitoring.coreos.com creates prometheusrules. We deploy these changes through GitOps(Flux)

The prometheusrules can be changed manually only. What we want to do is to do it from GitOps repository. But The only way to do is to put the whole prometheusrules file and there change the specific section of alert that needs to be changed. If we keep only one, which needs to be updated, once it gets applied, it removes rest of the default rules. This is not ideal.

I would like to have a feature that would patch the specific rules from prometheusrules and update only that rule only.

Describe the solution you'd like.

Provide editable prometheus rules to update those sections, when needed. Something in line with : additionalPrometheusRulesMap, where we will be able to update the default rules

Describe alternatives you've considered.

I have put the whole prometheusrules file and there change the specific section of alert that needs to be changed. If we keep only one, which needs to be updated, once it gets applied, it removes rest of the default rules.

Additional context.

No response

@sambitr sambitr added the enhancement New feature or request label May 3, 2024
@zeritti zeritti changed the title Feature to update the default prometheusrules, like CPUThrottlingHigh value [kube-prometheus-stack] Feature to update the default prometheusrules, like CPUThrottlingHigh value May 5, 2024
@LeoQuote
Copy link
Contributor

LeoQuote commented May 8, 2024

It can be done by disable the specific alert rule and redefine it in

additionalPrometheusRulesMap: {}

unfortunately those rules are generated by a script, if you want to provide such feature, you can try to edit the script and generate relating rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants