Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.2.1] Release Tracker #3409

Open
dbort opened this issue Apr 29, 2024 · 7 comments
Open

[v0.2.1] Release Tracker #3409

dbort opened this issue Apr 29, 2024 · 7 comments
Assignees
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@dbort
Copy link
Contributor

dbort commented Apr 29, 2024

The v0.2.1 release will be cut from the "release/0.2" branch for critical fixes to the v0.2.0 release. Date TBD

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Focus on stability and documentation correctness. Ideally only low risk changes may be cherry-picked from main:

  1. Critical fixes in core components: build, exir, backends, runtime, sdk
  2. Bug fixes in demos/examples. No new features/experiments
  3. Critical bug fixes based on community feedback
  4. Documentation improvements
  5. Test/CI fixes
  6. Release branch specific changes (e.g. change version identifiers)

Any core components changes and other change will require special dispensation from the release managers (currently @guangy10 @mergennachin @dbort ). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.
    Option 1: Use pytorchbot to cherry pick a PR that has been committed to the main branch using @pytorchbot cherry-pick command as follows.

    @pytorchbot cherry-pick --onto release/0.2 -c {regression,critical,fixnewfeature,docs,release}
    
    usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                             {regression,critical,fixnewfeature,docs,release}
    
    Cherry pick a pull request onto a release branch for inclusion in a release
    
    optional arguments:
      --onto ONTO           Branch you would like to cherry pick onto (Example: release/0.2)
      --fixes FIXES         Link to the issue that your PR fixes (i.e. https://github.com/pytorch/executorch/issues/2345)
      -c {regression,critical,fixnewfeature,docs,release}
                      A machine-friendly classification of the cherry-pick reason.
                      
    

    Option 2: Manually create a cherry pick PR using git command as follows.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/0.2
    git checkout release/0.2
    git cherry-pick -x abcdef12345
    
    # Submit a PR based against 'release/0.2' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/0.2
    
    
  3. Make a request below with the following format:

Link to landed trunk PR:
* 

Link to release branch PR:
* 

Criteria category and reasons:
* 
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

0.2.1

@dbort dbort self-assigned this Apr 29, 2024
@dbort dbort added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 29, 2024
@dbort dbort pinned this issue Apr 29, 2024
@Olivia-liu
Copy link
Contributor

Olivia-liu commented Apr 30, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • cmake file fix to make sdk tutorial work

@dbort: Since this makes code changes, don't merge this until closer to the 0.2.1 launch. Users are still instructed to check out the v0.2.0 tag, which won't contain this PR. And any docs changes that rely on this code change will break for those users.

@Olivia-liu
Copy link
Contributor

Olivia-liu commented Apr 30, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:


@dbort: Since this depends on code changes, don't merge this until closer to the 0.2.1 launch. Users are still instructed to check out the v0.2.0 tag, which won't contain the code changes. And any docs changes that rely on this code change will break for those users.

@Olivia-liu
Copy link
Contributor

Olivia-liu commented May 2, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

  • doc: simplify SDK tutorial doc

@dbort: Since this depends on code changes, don't merge this until closer to the 0.2.1 launch. Users are still instructed to check out the v0.2.0 tag, which won't contain the code changes. And any docs changes that rely on this code change will break for those users.

@Gasoonjia
Copy link
Contributor

Gasoonjia commented May 3, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:
Unblock nanogpt for dynamic export


@dbort merged

@cccclai
Copy link
Contributor

cccclai commented May 3, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:
A bug for the backend delegate, hopefully it can be cherry picked soon. Fortunately no in tree backends are using it, but there are a few new out tree backends and I'm afraid they might use it.


@dbort merged

@dbort
Copy link
Contributor Author

dbort commented May 3, 2024

Link to landed trunk PR:

Link to release branch PR:

Criteria category and reasons:

@dbort
Copy link
Contributor Author

dbort commented May 16, 2024

Link to landed trunk PR:

Link to release branch PR:

  • PLACEHOLDER

Criteria category and reasons:

  • Fixes a pte export issue in some environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants