Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream users have dependences on cmake variables and internals, making cmake a compatibility surface #3501

Open
mikekgfb opened this issue May 3, 2024 · 0 comments
Assignees

Comments

@mikekgfb
Copy link
Contributor

mikekgfb commented May 3, 2024

x-ref: https://github.com/pytorch/torchchat/issues/655

We're resolving https://github.com/pytorch/torchchat/issues/655 by pinning, but after we're in beta, downstream projects that need to build with cmake may expect their cmake files to work reliably, amking cmake and possibly internal cmake variables a compatibility surface.

We might be deliberate adn publish what users can use with a commitment to keep that interface as solid as possible, using TC to stress test (if TC can't use the defined interface, then maybe the interface is not sufficient?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants