Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISABLED test_ring_attention_compile_attention_fn1 (__main__.RingAttentionTest) #126252

Closed
huydhn opened this issue May 15, 2024 · 1 comment
Closed

DISABLED test_ring_attention_compile_attention_fn1 (__main__.RingAttentionTest) #126252

huydhn opened this issue May 15, 2024 · 1 comment
Labels
module: rocm AMD GPU support for Pytorch oncall: distributed Add this issue/PR to distributed oncall triage queue skipped Denotes a (flaky) test currently skipped in CI.

Comments

@huydhn
Copy link
Contributor

huydhn commented May 15, 2024 •
edited by pytorch-bot bot

Platforms: rocm

This test was disabled because it is failing on main branch (recent examples).

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang
@pytorch-bot pytorch-bot bot added the skipped Denotes a (flaky) test currently skipped in CI. label May 15, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 15, 2024

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_ring_attention_compile_attention_fn1 (__main__.RingAttentionTest)
  • Platforms for which to skip the test: rocm
  • Disabled by huydhn

Within ~15 minutes, test_ring_attention_compile_attention_fn1 (__main__.RingAttentionTest) will be disabled in PyTorch CI for these platforms: rocm. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch skipped Denotes a (flaky) test currently skipped in CI. and removed skipped Denotes a (flaky) test currently skipped in CI. labels May 15, 2024
@mikaylagawarecki mikaylagawarecki added the oncall: distributed Add this issue/PR to distributed oncall triage queue label May 15, 2024
@jithunnair-amd jithunnair-amd mentioned this issue May 15, 2024
Closed
ZelboK pushed a commit to ZelboK/pytorch that referenced this issue May 19, 2024
@jithunnair-amd @ZelboK
Add distributed/_tensor/test_attention to ROCM_BLOCKLIST (pytorch#126336
60fb3ef 
)

Fixes pytorch#125504
Fixes pytorch#126252
Fixes pytorch#126296
Fixes pytorch#126330

This PR doesn't really fix the RingAttentionTest tests for ROCm, but explicitly adds the whole test file to ROCM_BLOCKLIST to get a clean signal on ROCm distributed CI. We will enable these tests in a follow-up PR.

Pull Request resolved: pytorch#126336
Approved by: https://github.com/huydhn, https://github.com/pruthvistony
pruthvistony pushed a commit to ROCm/pytorch that referenced this issue May 20, 2024
@jithunnair-amd @pruthvistony
Add distributed/_tensor/test_attention to ROCM_BLOCKLIST (pytorch#126336
0c4eea8 
)

Fixes pytorch#125504
Fixes pytorch#126252
Fixes pytorch#126296
Fixes pytorch#126330

This PR doesn't really fix the RingAttentionTest tests for ROCm, but explicitly adds the whole test file to ROCM_BLOCKLIST to get a clean signal on ROCm distributed CI. We will enable these tests in a follow-up PR.

Pull Request resolved: pytorch#126336
Approved by: https://github.com/huydhn, https://github.com/pruthvistony
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: rocm AMD GPU support for Pytorch oncall: distributed Add this issue/PR to distributed oncall triage queue skipped Denotes a (flaky) test currently skipped in CI.
Projects
PyTorch on ROCm
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add distributed/_tensor/test_attention to ROCM_BLOCKLIST ROCm/pytorch
2 participants
@huydhn @mikaylagawarecki