Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] clone instead of to_tensordict #100

Open
vmoens opened this issue Dec 2, 2022 · 0 comments
Open

[Feature Request] clone instead of to_tensordict #100

vmoens opened this issue Dec 2, 2022 · 0 comments
Assignees
@vmoens
Labels
enhancement New feature or request

Comments

@vmoens
Copy link
Contributor

vmoens commented Dec 2, 2022

Motivation

The behaviour of clone is rather poorly defined. We should use to_tensordict instead.
Some clone methods rely on copy, which is messed up for tensordict classes as it does keeps pointers to previous metadata.
Having a clone that only returns pure TensorDict would be cleaner.
@vmoens vmoens added the enhancement New feature or request label Dec 2, 2022
@vmoens vmoens self-assigned this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoens vmoens

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmoens