Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making BaseColumn::genericUnaryUDF and the family free functions #197

Open
OswinC opened this issue Feb 11, 2022 · 0 comments
Open

Making BaseColumn::genericUnaryUDF and the family free functions #197

OswinC opened this issue Feb 11, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@OswinC
Copy link
Contributor

OswinC commented Feb 11, 2022

BaseColumn::genericUnaryUDF
BaseColumn::genericBinaryUDF
BaseColumn::genericTrinaryUDF

https://github.com/facebookresearch/torcharrow/blob/main/csrc/velox/column.h#L364-L377

This is in the Eager Mode/Velox Backend.

The generic UDF call methods should be general enough to not be bound to any columns. For example when there are no arguments or all arguments are scalars, conceptually this call is not bound to any columns. Technically they are static functions so don't require users to bind the calls to any column, but having these functions in the BaseColumn class makes them "sound" like being bound to BaseColumn. This is mostly a cosmetic change for new joiners to start with. More work will be required to truly make a UDF call interface that allows any forms of inputs.

Let's move these functions out of the BaseColumn class and make them free

@OswinC OswinC added the good first issue Good for newcomers label Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant