[ActiveRecord] Fixes wrong time field's default day with timezone #51797
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to fix #51679, a bug that appears when working with time field and timezones.
Basically, the bug occurs when ActiveRecord deserialized time field's day in other day but not the default one (01-01-2000), and it impacts validations and comparisons.
More details from the bug in the issue #51679.
Detail
This Pull Request changes the deserialized method
TimeZoneConverter
to always set the day for (01-01-2000) when we are working with the default time field.Additional information
For alternative solutions, we have some options thanks to mkbehbehani #51679 (comment)
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]