Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent PCam2D Limit from resetting if an invalid path is applied #303

Closed
ramokz opened this issue May 17, 2024 · 0 comments
Closed

Prevent PCam2D Limit from resetting if an invalid path is applied #303

ramokz opened this issue May 17, 2024 · 0 comments
Labels
2D Issues concerning 2D scenes enhancement New feature or request phantom camera Related to PhantomCamera nodes
Milestone

Comments

@ramokz
Copy link
Owner

ramokz commented May 17, 2024

Project Type

2D

Feature Description

Based on #299

If one attempts to set a limit_target through code with an invalid NodePath, then the limit_target will reset even if it has an existing valid limit target.

Ideally, it should print an error to inform the user that an invalid path was set and consequently not reset the limit size. Resetting the limit should only occur if the applied limit_target value is explicitly set to null.

Use Cases

When applying a limit target but accidentally applies an invalid NodePath reference.

(Optional) Proposed Solution

No response

@ramokz ramokz added enhancement New feature or request phantom camera Related to PhantomCamera nodes 2D Issues concerning 2D scenes labels May 17, 2024
@ramokz ramokz added this to the 0.7.1 milestone May 17, 2024
@ramokz ramokz closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2D Issues concerning 2D scenes enhancement New feature or request phantom camera Related to PhantomCamera nodes
Projects
Status: Done
Development

No branches or pull requests

1 participant