Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-" as a valid parameter for input/output parameters #216

Open
j824h opened this issue Apr 21, 2024 · 5 comments
Open

Add "-" as a valid parameter for input/output parameters #216

j824h opened this issue Apr 21, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@j824h
Copy link

j824h commented Apr 21, 2024

Reading from the standard input like many other command line tools could be helpful.

Especially, with edge-playback it would allow a streamlined workflow completely free of intermediate files.

@rany2
Copy link
Owner

rany2 commented Apr 21, 2024

edge-tts already supports this, it's only edge-playback that has this limitation. What you could do is the following:

<some program> | edge-tts --file /dev/stdin 2>/dev/null | mpv -

@j824h
Copy link
Author

j824h commented Apr 22, 2024

That makes sense. I see /dev/stdin is a file of course.

Still you wouldn't plan to alias with - as mpv does?

@rany2
Copy link
Owner

rany2 commented Apr 22, 2024

/dev/stdin is actually an alias for stdin, it's handled in edge-tts so it works even if that file doesn't exist (i.e., this works on Windows too)

@j824h
Copy link
Author

j824h commented Apr 22, 2024

I see /dev/stdin is actually an alias that works even for Windows.
I suppose you want to keep it as the only and correct way?

@rany2
Copy link
Owner

rany2 commented Apr 22, 2024

To be honest, I think it's quite confusing. I'll update it and add - as a supported parameter. You would never guess this if you didn't check the code.

@rany2 rany2 changed the title Reading from standard input Add "-" as a valid parameter for --file Apr 22, 2024
@rany2 rany2 changed the title Add "-" as a valid parameter for --file Add "-" as a valid parameter for output parameters Apr 22, 2024
@rany2 rany2 changed the title Add "-" as a valid parameter for output parameters Add "-" as a valid parameter for input/output parameters Apr 22, 2024
@rany2 rany2 added enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants