Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen Reader Accessibility is Missing #313

Open
StormProductionsMusic opened this issue Jul 1, 2021 · 13 comments
Open

Screen Reader Accessibility is Missing #313

StormProductionsMusic opened this issue Jul 1, 2021 · 13 comments
Labels
enhancement New feature or request GUI Theming, Tooltips, Details, etc

Comments

@StormProductionsMusic
Copy link

Describe the bug
Not accessible with a screen reader such as NVDA.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'nvaccess.org' and install 'NVDA'
  2. Launch the WhyNotWin11 app and try to see the results using the screen reader only

Expected behavior
The screen reader will let you hear the actual results.

Screenshots
No screenshots as it's about visually impaired and/or blind people.

Desktop (please complete the following information):

  • OS: Windows
  • Version: 2.3.0.3

Additional context
There are a lot of visually impaired and/or blind users that are using Windows, and that would also like to know whether their systems are compatible with Windows 11.
@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 1, 2021

Please see #258 and comments

@micwoj92 micwoj92 added the enhancement New feature or request label Jul 1, 2021
@StormProductionsMusic
Copy link
Author

Please see #258 and comments

Unfortunately, there are too many comments in there, and due to my visual impairment, my screen reader can't load all of them.
Could you please tell me which is the most important in there? The shortcuts mentioned don't seem to work..

@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 1, 2021 •
edited

This pull request was to add JAWS, NVDA andSapi5. It is not approved yet. NVDA compatibility was removed due to us being uncertain (it has different license than this software). It still needs to be reviewed and approved by Robert, but you can already download and test it.

Link below is to download zip, feel free to test (no NVDA, but maybe you have other readers ) and share feedback. It will be very important. Thanks!

https://github.com/rcmaehl/WhyNotWin11/suites/3127806850/artifacts/71722850

@StormProductionsMusic
Copy link
Author

No, I have no other screen readers - I only have NVDA.
Please let me know when, and if NVDA compatibility will be a thing.

Thanks.

@rmcpantoja
Copy link
Contributor

Hi @StormProductionsMusic
The first. Did you activate the enanced accessibility? Because when you open WhyNotWin11.au3 with the accessibility script included, when opening the prigram, the first thing is to ask yourself if you want to activate accessibility through an MSGBox. I don't know if you haven't done it, but I just tried it and it works for me with sapi5. The thing is, as @micwoj92 explained, originally my accessibility swite supported JAWS, NVDA and sapi 5 but the support for NVDA has been removed due to licensing issues, but it works great with sapi 5 for now until there is any decision with NVDA.
Here is the list of keybindings: This, I reiterate, works if Enhanced Accessibility is turned on.
CTRL + SHIFT + 1: VIOS type information and if it is compatible.
CTRL + SHIFT + 2: CPU information.
CTRL + SHIFT + 3: GPT information.
CTRL + SHIFT + 4: Installed ram information.
CTRL + SHIFT + 5: Secure boot information.
CTRL + SHIFT + 6: Hard disk information.
CTRL + SHIFT + 7: TPM version information and if it is compatible.
CTRL + SHIFT + c: Copy the last resource of the spoken system to the clipboard where it can be pasted anywhere.

@rmcpantoja
Copy link
Contributor

Hi, I have solved the problems with the code and fixed everything.
Especially in the accessibility script, when creating the "config" folder that stores the settings in the script folder. What happens is that in the main script of the program the working directory was changed to the system directory, so privileges are needed, but it is already corrected and perhaps that is the problem that prevented the script from working.

@StormProductionsMusic
Copy link
Author

StormProductionsMusic commented Jul 1, 2021 •
edited

Hi, I have downloaded the archive given in this issue, and enabled the enhanced accessibility script when running. Still, when pressing ctrl+shift+, there's so speech while the window is open.
Tried shutting down NVDA and still no good results.
Do I have to click "Check for Updates" and try pressing yes on the updater prompt?

@rmcpantoja
Copy link
Contributor

Hi,
I don't know what commit you downloaded. The first included NVDA but there were still things to improve, but in the latter everything is ready, only that for now NVDA is no longer taken into account. It's weird what happens to you, since the accessibility script works perfectly for me when I press one of the 8 key combinations and it reads me with the voice I have in sapi5. Anyway, I will update the main script when there are changes to it.

@StormProductionsMusic
Copy link
Author

Can you please give me the link to the version that you have and for which the accessibility script works as expected, so I can test it? Thanks.

@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 1, 2021

@StormProductionsMusic
This should be the latest version from before the NVDA was removed:
https://github.com/rcmaehl/WhyNotWin11/suites/3125228223/artifacts/71643119

@rmcpantoja
Copy link
Contributor

rmcpantoja commented Jul 1, 2021 •
edited

No, the version that really works is this, that is, the last one that was compiled, which fixes a major bug with the configuration folder. I say important because that version, the program had the script directory change, and the configuration folder is used to save the reader's configurations, that is, what screen reader is being used. This is the one that really works:
https://github.com/rcmaehl/WhyNotWin11/suites/3145088388/artifacts/72267180

@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 1, 2021

Yes, but that version that you linked doesnt support NVDA, does it?

@rmcpantoja
Copy link
Contributor

Yes, but that version that you linked doesnt support NVDA, does it?

NO, it is not compatible with NVDA, that is, it is the latest version that was built a few hours ago and it works definitely without any problem.

rcmaehl added a commit that referenced this issue Jul 2, 2021
@rcmaehl
Start on Settings Menu
95639ac 
To Do:
Add Option to Run #324
Add Theme Settings #314,
Add Accessibility Settings #313, #258
Add Language Selector #195
Allow importing languages
Add Translator Credit back in
micwoj92 added a commit to Qazy147/WhyNotWin11 that referenced this issue Jul 2, 2021
@micwoj92
Squashed commit of the following:
c31e252 
commit c5af837
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 17:48:23 2021 -0400

    Create CONTRIBUTING.md

commit 2eef0a9
Merge: eb1b451 dfe3a9e
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 17:15:34 2021 -0400

    Merge pull request rcmaehl#322 from PierreGrillet/refactoring-CPU-check

    Refactor CPU compatibility check code

commit eb1b451
Merge: c632983 8e22b89
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 17:08:28 2021 -0400

    Merge pull request rcmaehl#332 from Qazy147/patch-7

    Update WhyNotWin11.au3

commit c632983
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 22:54:17 2021 +0200

    WhyNotWin11.au3 + Local Const $DPI_RATIO (rcmaehl#348)

    Co-authored-by: Robert C. Maehl <rcmaehl@aol.com>

commit 157f20c
Merge: 2b174e2 9bc4947
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 16:45:02 2021 -0400

    Merge pull request rcmaehl#350 from mlipok/www_whynotwin

    Feature: Open URL "https://www.whynotwin11.org/"

commit 2b174e2
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 22:28:57 2021 +0200

    Au3Check - fix - Local $hJob "already declared" (rcmaehl#346)

commit ae7abc3
Author: micwoj92 <45581170+micwoj92@users.noreply.github.com>
Date:   Fri Jul 2 22:22:10 2021 +0200

    Fix rcmaehl#335

commit d01bd00
Author: micwoj92 <45581170+micwoj92@users.noreply.github.com>
Date:   Fri Jul 2 21:32:48 2021 +0200

    update metadata

commit ac8cbc2
Author: ARAKI Musashi <arakim@users.noreply.github.com>
Date:   Sat Jul 3 04:31:47 2021 +0900

    correct a typo (rcmaehl#342)

commit 9bc4947
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 20:54:07 2021 +0200

    GUICtrlSetCursor for $h_WWW

commit 5b4e4b3
Author: Oleg Chashko <62497891+Oleg-Chashko@users.noreply.github.com>
Date:   Fri Jul 2 20:07:43 2021 +0200

    Update 0419.lang (rcmaehl#344)

    Update metadata, Font sizes, Improved Russian translation

commit 1bdb4f5
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 19:59:21 2021 +0200

    WhyNotWin11.au3 "https://www.whynotwin11.org/"

commit 87dc335
Author: Oleg Chashko <62497891+Oleg-Chashko@users.noreply.github.com>
Date:   Fri Jul 2 19:55:54 2021 +0200

    Update 0422.lang (rcmaehl#343)

    Update Font sizes, Improved Ukrainian translation

commit 8e22b89
Merge: e48dc90 1d103eb
Author: Qazy147 <86588462+Qazy147@users.noreply.github.com>
Date:   Fri Jul 2 18:21:18 2021 +0200

    Merge branch 'rcmaehl:main' into patch-7

commit 1d103eb
Merge: 96c8a7f 1022dbb
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 12:12:45 2021 -0400

    Merge pull request rcmaehl#338 from mlipok/patch-5

    WhyNotWin11.au3 + #AutoIt3Wrapper_Run_AU3Check=Y

commit 96c8a7f
Merge: 7a68f80 3412fc6
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 12:12:12 2021 -0400

    Merge pull request rcmaehl#337 from mlipok/patch-4

    ResourcesEx.au3 - $__WINVER > _WinAPI_GetVersion()

commit 7a68f80
Merge: 81269b9 2437991
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 12:11:48 2021 -0400

    Merge pull request rcmaehl#336 from mlipok/patch-3

    _WMIC.au3 - Au3Check compabliity - _GetTPMInfo

commit 81269b9
Author: micwoj92 <45581170+micwoj92@users.noreply.github.com>
Date:   Fri Jul 2 18:01:22 2021 +0200

    Fix Availabe typo

commit e48dc90
Author: Qazy147 <86588462+Qazy147@users.noreply.github.com>
Date:   Fri Jul 2 13:29:12 2021 +0200

    Update WhyNotWin11.au3

commit dfe3a9e
Author: PierreGrillet <34492324+PierreGrillet@users.noreply.github.com>
Date:   Thu Jul 1 22:40:44 2021 +0200

    Refactor CPU compatibility check code

    Enhancement
    Factorizing GUI code from CPU checking list selection cases. (2/3 shorter)
    Update : Applied Requested Changes by @rcmaehl in rcmaehl#322, merge with main

commit 581f5c1
Author: micwoj92 <45581170+micwoj92@users.noreply.github.com>
Date:   Fri Jul 2 13:12:21 2021 +0200

    Re add translator

     @PierreGrillet seems like one was accidentally removed, you added here rcmaehl#226

commit a24800a
Author: PierreGrillet <34492324+PierreGrillet@users.noreply.github.com>
Date:   Fri Jul 2 13:09:14 2021 +0200

    Update French translation (rcmaehl#323)

    * Update French translation

    - Adding font size (reduce Large to 14)
    - Fix Clipping text
    - Translate CPU and OS

    * [fr-FR] Remove ghost user from translaters

commit 2437991
Merge: 68111b4 9c7c6ed
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:41:30 2021 +0200

    Merge branch 'rcmaehl:main' into patch-3

commit 3412fc6
Merge: 4c018e2 9c7c6ed
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:32:57 2021 +0200

    Merge branch 'rcmaehl:main' into patch-4

commit 1022dbb
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:30:42 2021 +0200

    WhyNotWin11.au3 + #AutoIt3Wrapper_Run_AU3Check=Y

    Also full #AutoIt3Wrapper_Au3Check_Parameters added
    to be sure next PR from other contributors will come with no other problems.

commit 9c7c6ed
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:22:36 2021 +0200

    WhyNotWin11.au3 $hModule not declared (rcmaehl#331)

    Fixes "error: $hModule: undeclared global variable."

commit 4c018e2
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:21:37 2021 +0200

    ResourcesEx.au3 - $__WINVER > _WinAPI_GetVersion()

    $__WINVER was removed from WinAPIInternals.au3 at 08-04-2018 so is not present in recent beta

commit 68111b4
Author: Michał Lipok <mlipok@users.noreply.github.com>
Date:   Fri Jul 2 11:04:51 2021 +0200

    _WMIC.au3 - Au3Check compabliity - _GetTPMInfo

    fixed duplicated static and move static to top

commit 3c27fe1
Author: Qazy147 <86588462+Qazy147@users.noreply.github.com>
Date:   Fri Jul 2 10:04:42 2021 +0200

    Update WhyNotWin11.au3

    Line 641 overwrites any previous settings.

commit 95639ac
Author: Robert C. Maehl <rcmaehl@aol.com>
Date:   Fri Jul 2 02:59:42 2021 -0400

    Start on Settings Menu

    To Do:
    Add Option to Run rcmaehl#324
    Add Theme Settings rcmaehl#314,
    Add Accessibility Settings rcmaehl#313, rcmaehl#258
    Add Language Selector rcmaehl#195
    Allow importing languages
    Add Translator Credit back in
@rcmaehl rcmaehl added the GUI Theming, Tooltips, Details, etc label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request GUI Theming, Tooltips, Details, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rcmaehl @micwoj92 @rmcpantoja @StormProductionsMusic