Allow users to delete their chat histories #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…displays menu on right click
…debar electron/main/storeHandlers: Added remove-chat-history ipcHandler
src/components/ChatsSidebar: Added useEffect to updateAllChatHistories src/components/FileEditorContainer: Passed setShowChatbot to SidebarManager so we can hide chat only if we're viewing it and choose to delete it. src/components/MainSidebar: Passed setShowChatbot to ChatsSidebar
samlhuillier
requested changes
May 18, 2024
electron/main/Store/storeHandlers.ts
Outdated
| @@ -198,6 +198,38 @@ export const registerStoreHandlers = ( | |||
| const vaultChatHistories = allChatHistories[vaultDir] || []; | |||
| return vaultChatHistories.find((chat) => chat.id === chatId); | |||
| }); | |||
|
|
|||
| ipcMain.handle("update-all-chat-history", (event, chatID: string) => { | |||
There was a problem hiding this comment.
Looks like we no longer use this handler. Perhaps remove it?
electron/preload/index.ts
Outdated
| @@ -289,6 +294,9 @@ contextBridge.exposeInMainWorld("electronStore", { | |||
| updateChatHistory: (chatHistory: ChatHistory) => { | |||
| ipcRenderer.invoke("update-chat-history", chatHistory); | |||
| }, | |||
| updateAllChatHistories: (chatID: string) => { | |||
There was a problem hiding this comment.
Given that this calls the remove handler, perhaps it should be called removeChatHistory?
src/components/Chat/ChatsSidebar.tsx
Outdated
| if (chatID === currentSelectedChatID.current) { | ||
| setShowChatbot(false); | ||
| } | ||
| window.electronStore.updateAllChatHistories(chatID); |
There was a problem hiding this comment.
Nit but we should probably update the store first and then update the renderer process' record of the chat metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is no way to delete chat histories. The following PR allows users to:
Closes #245