Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link for the blue pill support crate #84

Open
gbip opened this issue Sep 14, 2018 · 5 comments
Open

Dead link for the blue pill support crate #84

gbip opened this issue Sep 14, 2018 · 5 comments

Comments

@gbip
Copy link
Contributor

gbip commented Sep 14, 2018

Hello !
The blue pill support crate redirect to the stm32f103 hal.

@therealprof
Copy link
Contributor

@gbip Why is that a problem and how would you like to see it addressed?

@gbip
Copy link
Contributor Author

gbip commented Sep 14, 2018

I think that this is misdirecting because one would expect the link to send us to a board support crate, while it is sending us to an hal implementation. Maybe we should remove it from this category ?

@therealprof
Copy link
Contributor

I think @japaric idea here was that there's actually very little blue-pill specific in that crate that is not in the hal itself (because there's very little on the blue-pill board) so the hal can really take over the role of a board specific crate. I stumbled over the exact same redirect a while back but was not aware that this might be confusing.

@japaric Would it be okay for you if we removed the BSP crate from the list?

@irwineffect
Copy link

irwineffect commented Nov 30, 2018

I agree the link should be removed. While a BSP crate for the blue pill would be pretty minimal and not much on top of the HAL, japaric/stm32f103xx-hal is still not a BSP.

@jonas-schievink
Copy link
Contributor

This can probably be closed now that #146 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants