-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make crashes dump mir to build dir #125032
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Some changes occurred in src/tools/compiletest cc @jieyouxu |
src/tools/compiletest/src/runtest.rs
Outdated
let mir_dump_dir = self.get_mir_dump_dir(); | ||
remove_and_create_dir_all(&mir_dump_dir); | ||
let mut dir_opt = "-Zdump-mir-dir=".to_string(); | ||
dir_opt.push_str(mir_dump_dir.to_str().unwrap()); | ||
rustc.arg(dir_opt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind some abstraction. Could we even just stuff this in a closure and call it on both arms that need this?
a3248e1
to
848f3c2
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a71c3ff): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 679.977s -> 678.182s (-0.26%) |
Set
-Zdump-mir-dir
forcrashes
-style tests.Alternatively, we just remove
tests/crashes/124436.rs
, since if the only way to get it to repro is via-Zdump-mir
, then maybe it's not worth it to fix.Fixes #125029