RFC: allow to remove shipping_address or billing_address from Checkout or Order

[Air-t]

Problem

Currently, there is no way to remove the shipping_addres or billing_address from the Checkout or Order.

Current flow:

mutation CheckoutCreate {
  checkoutCreate(
    input: {
      channel: "default-channel", 
      email: "test@example.com", 
      lines: [{quantity: 1, variantId: "UHJvZHVjdFZhcmlhbnQ6Mzg0"}], 
      shippingAddress: {firstName: "Mr", lastName: "Test", streetAddress1: "Teczowa 7", country: PL, postalCode: "53-030", city: "Wroclaw"}
    }
  ) {
    errors {
      field
      message
    }
    checkout {
      id
      lines {
        id
        variant {
          name
        }
      }
      shippingAddress {
        id
        firstName
        lastName
      }
    }
  }
}

try to remove the address:

mutation CheckoutRemoveAddress {
  checkoutShippingAddressUpdate(
    checkoutId: "Q2hlY2tvdXQ6NDk2NWMwOTctNjJhOS00NzEyLTkxZjAtZGMyOTg5M2RkZjEx"
    shippingAddress: {}
    validationRules: {checkRequiredFields: false, checkFieldsFormat:false, enableFieldsNormalization: false}
  ){
    checkout{
      id
      shippingAddress{
        id
        firstName
      }
    }
    errors{
      field
      message
    }
  }
}

1. General Assumptions

Add new mutations to allow removing addresses from Checkout and Order.

• checkoutShippingAddressRemove
• checkoutBillingAddressRemove
• orderShippingAddressRemove
• orderBillingAddressRemove

2. API changes

Mutations

  """
  Removes a shipping address from a checkout. 
  """
  checkoutShippingAddressRemove(
    """ID of a checkout to update."""
    id: ID!
  ): CheckoutShippingAddressRemove @doc(category: "Checkout")
  
  """
  Removes a billing address from a checkout. 
  """
  checkoutBillingAddressRemove(
    """ID of a checkout to update."""
    id: ID!
  ): CheckoutBillingAddressRemove @doc(category: "Checkout")
  
  """
  Removes a shipping address from an order. 
  """
  orderShippingAddressRemove(
    """ID of a draft order to update."""
    id: ID!
  ): OrderShippingAddressRemove @doc(category: "Order")
  
  """
  Removes a billing address from an order. 
  """
  orderBillingAddressRemove(
    """ID of a draft order to update."""
    id: ID!
  ): OrderBillingAddressRemove @doc(category: "Order")

3. Database changes

No response

4. UML diagrams

No response

5. To Do list

No response

6. To Test

No response

[korycins]

IMHO, I would say, that removing the address from checkout/order should have a separate mutations. Mostly to make it an explicit step that needs to be called. shippingAddressUpdate with an empty address could be called by mistake etc. With separate mutations, we are sure that this call was expected.
Also I would suggest using Remove/Detach instead of Delete. Delete suggests deleting the address, but this action is just detaching the address from the checkout/order. If the address is the customer's default one we don't delete it.

[fowczarek]

Also, we shouldn't forget to remove unused addresses.

[Air-t]

This RFC is dropped for now and will not be developed in near future