Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses a more recent version of easymock #887

Closed
wants to merge 1 commit into from

Conversation

johanvos
Copy link
Contributor

@johanvos johanvos commented Dec 2, 2022

Uses a more recent version of easymock where easymock/easymock#274 is fixed

Fix #886

Copy link
Contributor

@msgilligan msgilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my system and this fixes a build error on JDK 17, but seems to cause one on JDK 11 (macOS).

Copy link
Contributor

@msgilligan msgilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: This seems to cause a build problem (in the tests for driver-vlcj)

Update (again): PR #891 seems to resolve the issue caused by EasyMock 5 in compiling the tests for driver-vlcj

msgilligan pushed a commit to SupernautApp/webcam-capture that referenced this pull request Dec 14, 2022
@alexmao86
Copy link
Collaborator

thank you for your interests. this is not feature enhancement, I will block this

@alexmao86 alexmao86 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests are broken on Java 17
3 participants