Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sstable_manager: components reloader fiber should run with maintenance scheduling group #18675

Closed
lkshminarayanan opened this issue May 14, 2024 · 0 comments · Fixed by #18721
Closed

sstable_manager: components reloader fiber should run with maintenance scheduling group #18675

lkshminarayanan opened this issue May 14, 2024 · 0 comments · Fixed by #18721
Assignees
@lkshminarayanan
Labels
Backport candidate backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0

Comments

@lkshminarayanan
Copy link
Member

PR #18186 introduced a fiber that reloads reclaimed bloom filters when memory became available. The fiber currently runs in the main scheduling group. It should rather run with the maintenance scheduling group.
@lkshminarayanan lkshminarayanan added backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0 labels May 14, 2024
@lkshminarayanan lkshminarayanan self-assigned this May 14, 2024
lkshminarayanan added a commit to lkshminarayanan/scylladb that referenced this issue May 17, 2024
@lkshminarayanan
sstables_manager: use maintenance scheduling group to run components …
fa06902 
…reload fiber

Fixes scylladb#18675

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
@lkshminarayanan lkshminarayanan mentioned this issue May 17, 2024
Merged
denesb added a commit that referenced this issue May 20, 2024
@denesb
Merge 'sstables_manager: use maintenance scheduling group to run comp…
e1c4e6c 
…onents reload fiber' from Lakshmi Narayanan Sreethar

PR #18186 introduced a fiber that reloads reclaimed bloom filters when memory becomes available. Use maintenance scheduling group to run that fiber instead of running it in the main scheduling group.

Fixes #18675

Closes #18721

* github.com:scylladb/scylladb:
  sstables_manager: use maintenance scheduling group to run components reload fiber
  sstables_manager: add member to store maintenance scheduling group
mergify bot pushed a commit that referenced this issue May 20, 2024
@lkshminarayanan @mergify
sstables_manager: use maintenance scheduling group to run components …
1f235e6 
…reload fiber

Fixes #18675

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
(cherry picked from commit 6f58768)

# Conflicts:
#	sstables/sstables_manager.cc
@mergify mergify bot mentioned this issue May 20, 2024
Draft
mergify bot pushed a commit that referenced this issue May 20, 2024
@lkshminarayanan @mergify
sstables_manager: use maintenance scheduling group to run components …
ac9f23a 
…reload fiber

Fixes #18675

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
(cherry picked from commit 6f58768)

# Conflicts:
#	sstables/sstables_manager.cc
@mergify mergify bot mentioned this issue May 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkshminarayanan lkshminarayanan

Labels
Backport candidate backport/5.2 Issues that should be backported to 5.2 branch once they'll be fixed backport/5.4 Issues that should be backported to 5.4 branch once they'll be fixed backport/6.0
Projects
None yet
Milestone
No milestone
2 participants
@lkshminarayanan @scylladb-promoter