Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Monkey365 is not handling duplicate entries in Analysis parameter #93

Open
silverhack opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@silverhack
Copy link
Owner

silverhack commented Feb 27, 2024

What happened?
Duplicate values in Analysis should raise some kind of warning. This would help prevent mistakes when working with larger tenants and complex configs.

How to reproduce it
Steps to reproduce the behavior:

$param = @{
    Instance = 'Microsoft365';
    Analysis = @("SharePointOnline","Microsoft365","ExchangeOnline","SharePointOnline","Purview","MicrosoftTeams");
    PromptBehavior = 'SelectAccount';
    IncludeEntraID = $true;
    ExportTo = @("CSV","JSON","HTML");
}
Invoke-Monkey365 @param

The above command will be executed without throwing any error (or warning).

Expected behavior
Duplicate values in Analysis should raise some kind of warning or throw an error.

From where are you running Monkey365?
Please, complete the following information:

  • Resource: [Docker container, workstation) all
  • OS: [e.g. Windows, Linux, etc. ] all
  • PowerShell Version [$PsVersionTable]: all versions
  • Monkey365 Version: Monkey365 v0.91.2-beta (dev)
@silverhack silverhack added the bug Something isn't working label Feb 27, 2024
@silverhack silverhack self-assigned this Feb 27, 2024
@silverhack
Copy link
Owner Author

Fix on dev branch.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant