Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Monkey365 causes exception when Analysis and IncludeEntraId parameters are not provided #98

Open
sssseossss opened this issue Apr 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sssseossss
Copy link

What happened?
using Pwsh7.4
Donwloaded newest version from develop branch, imported module, then invoke-monkey365 -> input credentials and get the following:
InvalidOperation: C:\users\XXXX\downloads\powershell-7.4.2-win-x64\Modules\monkey365\Invoke-Monkey365.ps1:455
Line |
455 | switch ($O365Object.Instance.ToLower()){
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| You cannot call a method on a null-valued expression.

How to reproduce it
as described above

Expected behavior
Program should just work

Screenshots or Logs
all info noted above
From where are you running Monkey365?
Please, complete the following information:

  • Resource: [Docker container, workstation) workstation
  • OS: [e.g. Windows, Linux, etc. ] Windows 11
  • PowerShell Version [$PsVersionTable]: 7.4.2
  • Monkey365 Version: Newest from develop branch
  • Others:

Additional context
Add any other context about the problem here.

@sssseossss sssseossss added bug Something isn't working status/needs-triage Needs triage labels Apr 25, 2024
@silverhack silverhack removed the status/needs-triage Needs triage label Apr 25, 2024
@silverhack silverhack changed the title [Bug]: cannot call a method on a null-valued expression. [Bug]: ~~cannot call a method on a null-valued expression.~~ Monkey365 causes exception when Analysis and IncludeEntraId parameters are not provided Apr 25, 2024
@silverhack silverhack changed the title [Bug]: ~~cannot call a method on a null-valued expression.~~ Monkey365 causes exception when Analysis and IncludeEntraId parameters are not provided [Bug]: Monkey365 causes exception when Analysis and IncludeEntraId parameters are not provided Apr 25, 2024
@silverhack
Copy link
Owner

Hi @sssseossss,

Renamed the issue as the title is not reflecting the actual issue.

Firstly, the execution is not a bug and you're executing Monkey365 incorrectly. Please, see docs about how to correctly execute Monkey365 against supported environments.

The instance parameter must be populated when the -IncludeEntraId is not set. Valid options are Azure and Microsoft365. You can find more information here.

On the other hand, Monkey365 should raise an error when both parameters are not provided. It's a bug and should be fixed shortly.

Thanks for using Monkey365!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants