Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix BaggingClassifier for column subsampling case #6429

Merged
merged 2 commits into from
May 22, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented May 15, 2024

Fixes #6427.

The problem was that _predict_proba did simply forget to subset columns of X.

The bug was not detected as the base classifier used in tests was DummyClassifier, which ignores X, and hence misses the failures in column subsetting of X entirely.

To cover the bug, the classifier was replaced by SummaryClassifier..

@fkiraly fkiraly added module:classification classification module: time series classification bugfix Fixes a known bug or removes unintended behavior labels May 15, 2024
@fkiraly fkiraly merged commit 62237ba into main May 22, 2024
54 checks passed
@fkiraly fkiraly deleted the fix-bagging-univariate branch May 22, 2024 23:53
geetu040 pushed a commit to geetu040/sktime that referenced this pull request Jun 4, 2024
Fixes sktime#6427.

The problem was that `_predict_proba` did simply forget to subset
columns of `X`.

The bug was not detected as the base classifier used in tests was
`DummyClassifier`, which ignores `X`, and hence misses the failures in
column subsetting of `X` entirely.

To cover the bug, the classifier was replaced by `SummaryClassifier.`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BaggingClassifier not working with WEASEL on multivariate data
1 participant