Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "sync" feature(s) #145

Open
uklotzde opened this issue Feb 5, 2023 · 2 comments
Open

Remove "sync" feature(s) #145

uklotzde opened this issue Feb 5, 2023 · 2 comments
Milestone

Comments

@uklotzde
Copy link
Member

uklotzde commented Feb 5, 2023

Bundling an opinionated synchronous API wrapper around the native, asynchronous API is unfortunate and wrong. It only causes trouble and misunderstandings. I recommend to remove it before releasing version 1.0.

If users need synchronous communication they should use a different library.

@vfiack
Copy link

vfiack commented Feb 28, 2023

If users need synchronous communication they should use a different library.

Do you have one to suggest?

@uklotzde
Copy link
Member Author

If users need synchronous communication they should use a different library.

Do you have one to suggest?

Unfortunately not.

Re-implementing the sync client(s) by reusing common parts from frame and codec but without the unnecessary Frankenstein-ean loop through the Tokio runtime would be the path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants