Observation in ServerHttpObservationFilter is never stopped for asynchronous requests #32730
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
status: waiting-for-triage
An issue we've not yet triaged or decided on
theme: observability
An issue related to observability and tracing
Spring Framework 6.0.19
CometD 7.0.10
Micrometer 1.12.5
I'm not exactly sure which component is responsible for this issue but since spring-web contains ServerHttpObservationFilter, I am submitting this bug here.
We have recently run into a memory leak of DefaultLongTaskTimer$SampleImpl. This was introduced with micrometer introducing histograms for http.server.requests.active.
The leak happens only for requests to CometD and it happens because those requests are asynchronous.
In https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/filter/ServerHttpObservationFilter.java:
The problem is that there is no corresponding callback that would close the Observation once asynchronous requests completes.
Thanks,
The text was updated successfully, but these errors were encountered: