Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need emptyPara for focusing caret? #3016

Open
lqez opened this issue Nov 8, 2018 · 2 comments
Open

Do we still need emptyPara for focusing caret? #3016

lqez opened this issue Nov 8, 2018 · 2 comments

Comments

@lqez
Copy link
Member

lqez commented Nov 8, 2018

We've used emptyPara as a non-empty value for browser compatibility issues as like as we discussed on #313.

I want to ask us whether we should use the same rule now or not.
I tested on some browsers on macOS and got errors on breaking paragraph tests but no issue on focusing caret.

If we don't need to use emptyPara, then several related issues can easily disappear.
Please share your opinions, @hackerwins and @easylogic and @diemendesign.

@DennisSuitters
Copy link
Member

If removing emptyPara doesn't adversely affect usage, and in turns resolves long-standing issues, then I see it as a good thing.

@1der1
Copy link

1der1 commented Sep 16, 2021

emptyPara adds unwanted code. Unfortunately, if you don't use it, you get uncaught exceptions. So you have to check for empty nodes when you remove emptyPara.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants