-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtu.be url does not work. I seems to work in an older version (0.8.10). Could you please fix as YouTube uses the youtu.be as default to share the url. #4628
Comments
There was a PR merged recently to address YouTube and Instagram videos, you may need to build the project on your local machine to get the changes. I have no ETA when a new release will occur. |
Hello, thanks for the reply. I changed a single line of code in the .js file to fix the youtu.be url to work.
Thank you.
…
On Mar. 25, 2024 at 8:04 p.m., Dennis Suitters ***@***.***> wrote:
There was a PR merged recently to address YouTube and Instagram videos, you may need to build the project on your local machine to get the changes. I have no ETA when a new release will occur.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
You can do that, obviously, just be aware that if you update, you'll have to edit that again. |
Hi which line did you change? i did a local yarn build as mentioned by Dennis, and now youtu.be links embed, but the code view doesn't accept iframe embed codes anymore. this means any non youtube platform like a soundcloud widget etc doesn't embed. i'll make a fork that's basically stable 8.1.8 with the youtu.be fix and link it here if someone can point me to the right direction. |
I don't know how to fix the code embedding in 8.1.9 but i was able to make a patch to summernote-lite.js 8.1.8 so that it uses the same regex as 8.1.9, enabling youtu.be and google drive as well as. including the patched summernote.lite.js file here, and if you have a bootstrap version you can do the same patch I did: I copied the regex patterns from 8.1.9 (around line 9080 in summernote-lite.js (CTRL+f or awk/grep for "createVideoNode")
and i used these to replace the corresponding section in 8.1.8. So if you use summernote lite like I do, you can copy my whole summernote-lite.js file and use it with the normal css and js.map that ship with 8.1.8 Azeem's Summernote-lite 8.1.8.2 Video/Youtu.be Fix: https://gist.github.com/azeemh/a8a933d7648c95eeb5847abd2aa13085 |
Checklist
Steps to reproduce
No response
Expected behavior
The youtu.be url should display a video preview as it does with the youtube.com url.
Current behavior
When adding a youtube.com url the video preview displays but the youtu.be url does not display anything. The older version mention does in fact work.
Minimal example reproducing the issue
https://summernote.org/
Environment
The text was updated successfully, but these errors were encountered: