Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook tests are failing #358

Open
manuel3108 opened this issue May 12, 2024 · 0 comments
Open

storybook tests are failing #358

manuel3108 opened this issue May 12, 2024 · 0 comments
Labels
adder:storybook confirmed bug Something isn't working upstream Can only be solved by an upstream project's changes

Comments

@manuel3108
Copy link
Member

Topic

tests, storybook

Version

invalid

Expected behavior

Test's should be passing.

Actual behavior

As found out by #357, storybook tests are currently failing. This is due to a misconfiguration in the storybook cli that fails to apply the changes to the package.json in certain circumstances. This issue has been reported to the remote and is currently tracked by storybookjs/storybook#27096

As described in the remote issue, removing --skip-install fixes this behavior, but will therefore prompt the user to install the dependencies twice, once by the storybook cli, and once by svelte-add. This could be solved within svelte-add, although I would prefer that the storybook cli works correctly.

@manuel3108 manuel3108 added confirmed bug Something isn't working upstream Can only be solved by an upstream project's changes adder:storybook labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adder:storybook confirmed bug Something isn't working upstream Can only be solved by an upstream project's changes
Projects
None yet
Development

No branches or pull requests

1 participant