[Translation] translation:extract with bundle - should also extract translations from PHP code

[cuchac]

Symfony version(s) affected

7.1

Description

Documentation mentions

The translation:extract command looks for missing translations in:
...
 - Any PHP file/class that injects or autowires the translator service and makes calls to the trans() method..
...

When bundle is specified, this does not work as stated. Following line limits path to extract texts to only bundle template folder:

symfony/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php

Line 159 in 29b00c2

$codePaths = [is_dir($bundleDir.'/Resources/views') ? $bundleDir.'/Resources/views' : $bundleDir.'/templates'];

I did not find any other official way to extract PHP code translations from bundle. I believe at least PHP files using translator service should be included in extracted bundle translations.

How to reproduce

php bin/console translation:extract --force fr AcmeBundle

Only translations from templates (AcmeBundle/templates) are extracted. No PHP trans() calls are extracted.

Possible Solution

Use result from $this->getRootCodePaths($kernel) and leave all files from given bundle.

symfony/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php

Lines 149 to 159 in 29b00c2

	$codePaths = $this->getRootCodePaths($kernel);
	$currentName = 'default directory';
	// Override with provided Bundle info
	if (null !== $input->getArgument('bundle')) {
	try {
	$foundBundle = $kernel->getBundle($input->getArgument('bundle'));
	$bundleDir = $foundBundle->getPath();
	$transPaths = [is_dir($bundleDir.'/Resources/translations') ? $bundleDir.'/Resources/translations' : $bundleDir.'/translations'];
	$codePaths = [is_dir($bundleDir.'/Resources/views') ? $bundleDir.'/Resources/views' : $bundleDir.'/templates'];

Additional Context

No response

[cuchac]

Would you accept contribution to handle this issue? Should there be any command-line parameter or it could be the default behavior?