-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support user-defined embedding dimensions in Generators #111
Labels
enhancement
New feature or request
Comments
Hey @bernard-ng , Yes I agree. Do you want to contribute on this one? |
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 10, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 10, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 17, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 17, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 17, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 25, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 25, 2024
bernard-ng
added a commit
to bernard-ng/LLPhant
that referenced
this issue
May 25, 2024
@MaximeThoonsen can you have a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://platform.openai.com/docs/api-reference/embeddings/create#embeddings-create-dimensions
It is possible to define the dimension of an embedding via the configuration of the service used, for openai via “dimensions” in the model options. Defining the dimension of embeddings can be interesting if you want to interchange different embedding generators (eg: research, benchmarking, etc...).
Currently, the size is defined statically:
I think this function should take into account customizations made by the user, or add a function to define the embedding dimension from the generator
What do you think?
The text was updated successfully, but these errors were encountered: