Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a data reader for Notion #5

Open
MaximeThoonsen opened this issue Aug 10, 2023 · 4 comments
Open

Create a data reader for Notion #5

MaximeThoonsen opened this issue Aug 10, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MaximeThoonsen
Copy link
Contributor

No description provided.

@MaximeThoonsen MaximeThoonsen added enhancement New feature or request good first issue Good for newcomers labels Aug 10, 2023
@MaximeThoonsen MaximeThoonsen changed the title Create a data loader for Notion Create a data reader for Notion Aug 10, 2023
@f-lombardo
Copy link
Contributor

Hi, I'd like to try to handle this issue as my first contribution. Could you give some more context about this?

@MaximeThoonsen
Copy link
Contributor Author

Hey @f-lombardo,
Thanks for this. The goal is to create a NotionDataReader class that loads the .md files of a notion export and creates Documents out of it. You can also named it MarkdownDataReader as it should mainly be a class that read correctly information from a Markdown file.

You can have a look here for the JS version : https://github.com/langchain-ai/langchainjs/blob/main/langchain/src/document_loaders/fs/notion.ts for a minimal version of it.

Does it help?

@f-lombardo
Copy link
Contributor

Hi @MaximeThoonsen , thank you very much for the infos. I hope to send you a PR soon.

@f-lombardo f-lombardo mentioned this issue May 24, 2024
Merged
@f-lombardo
Copy link
Contributor

Hi @MaximeThoonsen , what's your opinion about the continuation of this issue? Do you think that #129 will be enough, or that we should create a specific NotionReader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f-lombardo @MaximeThoonsen