Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinot query options to query #21902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naman-patel
Copy link

@naman-patel naman-patel commented May 9, 2024

Description

Currently no Pinot query options can be passed along with query. This means Pinot null handling cant be leveraged. This PR provides a way to provide these query options.

Additional context and related issues

The same PR was also implemented for Presto. Here is the reference to that.

Fixes #21897

Release notes

(x) Release notes are required, with the following suggested text:

# Pinot
* Allow users to configure Pinot query options. ({21897}`issuenumber`)

@naman-patel
Copy link
Author

@ebyhr addrressed your feedback except for the last one as I dont see a way to add those session properties in test framework.

@ebyhr
Copy link
Member

ebyhr commented May 23, 2024

Could you rebase on master to resolve conflicts?

@naman-patel
Copy link
Author

naman-patel commented May 24, 2024

Could you rebase on master to resolve conflicts?

@ebyhr Done

@naman-patel naman-patel force-pushed the enable-pinot-query-options branch 2 times, most recently from 46ed9af to 5c06c66 Compare May 24, 2024 20:33
@findinpath findinpath requested a review from ebyhr May 26, 2024 04:58
@ebyhr
Copy link
Member

ebyhr commented May 28, 2024

Please fix CI failure and add a query based test to BasePinotConnectorSmokeTest

Error:    TestDynamicTable.testQueryOptions:469 
expected: 
  "SET useMultistageEngine = true;
  SET skipUpsert = true;
  SELECT "FlightNum" FROM realtimeOnly_REALTIME LIMIT 50"
 but was: 
  "SET useMultistageEngine = true;
  SET skipUpsert = true;SELECT "FlightNum" FROM realtimeOnly_REALTIME LIMIT 50"

@naman-patel
Copy link
Author

@ebyhr review again?

@ebyhr
Copy link
Member

ebyhr commented May 29, 2024

@naman-patel Please handle #21902 (comment)

@naman-patel
Copy link
Author

@ebyhr @findinpath All things are addressed. If you merge this I have few more PRs for pinot connector. This is really blocking me at the moment.

@naman-patel naman-patel force-pushed the enable-pinot-query-options branch 2 times, most recently from c7148c1 to de79610 Compare May 31, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Pinot connector has no way to pass query option along with query
3 participants