-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pinot query options to query #21902
base: master
Are you sure you want to change the base?
Conversation
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotPageSourceProvider.java
Outdated
Show resolved
Hide resolved
8650993
to
fa7aa97
Compare
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotSessionProperties.java
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotSessionProperties.java
Show resolved
Hide resolved
5683c06
to
0d5cd9e
Compare
@ebyhr addrressed your feedback except for the last one as I dont see a way to add those session properties in test framework. |
42ec6de
to
25cc52f
Compare
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
Could you rebase on master to resolve conflicts? |
dafbc22
to
6917290
Compare
@ebyhr Done |
46ed9af
to
5c06c66
Compare
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
b457b56
to
f88f69f
Compare
Please fix CI failure and add a query based test to
|
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/TestPinotSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/query/TestQueryOptionsParsing.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/query/TestQueryOptionsParsing.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/query/TestQueryOptionsParsing.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
aa97a8c
to
6e2125d
Compare
@ebyhr review again? |
@naman-patel Please handle #21902 (comment) |
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Show resolved
Hide resolved
015c653
to
bb8bf53
Compare
@ebyhr @findinpath All things are addressed. If you merge this I have few more PRs for pinot connector. This is really blocking me at the moment. |
c7148c1
to
de79610
Compare
de79610
to
cb25080
Compare
Description
Currently no Pinot query options can be passed along with query. This means Pinot null handling cant be leveraged. This PR provides a way to provide these query options.
Additional context and related issues
The same PR was also implemented for Presto. Here is the reference to that.
Fixes #21897
Release notes
(x) Release notes are required, with the following suggested text: