fix: Ivy Failing Test: paddle - elementwise.logical_and #28405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishticode
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Hi @MuhammadNizamani
Thanks for the continued contributions 😊
As the functions seems to have an explicit handling for complex under if paddle.is_complex why are we excluding complex from supported types? and if this is not being handled properly then we should either try to fix the clause or remove it entirely and remove from supported types. In current state it doesn't make sense to me 🤔
|
@Ishticode I am so sorry I overlooked it. I am looking into it. |
|
any updates @MuhammadNizamani :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
locally passing on 200 examples
Related Issue
Closes #28404
Checklist
Socials