Fix: all API keys are correctly added when importing OpenAPI collection #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| brunoRequestItem.request.headers.push({ | ||
| uid: uuid(), | ||
| name: param.name, | ||
| value: '{{apiKey}}', |
There was a problem hiding this comment.
Hello,
With this line you generate a duplicated variable name, so you need to rework your collection after import.
Maybe a param.name in camelCase can do it?
value = '{{' +
param.name
.replace('x-', '')
.replaceAll('-', ' ')
.replace(/(?:^\w|[A-Z]|\b\w|\s+)/g, function(match, index) {
if (+match === 0) return ""; // or if (/\s+/.test(match)) for white spaces
return index === 0 ? match.toLowerCase() : match.toUpperCase();
})
+ '}}';There was a problem hiding this comment.
Hey , could you please explain how this code generate a duplicated variable name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2254
This PR addresses the issue where only one API key was being added to the collection when importing OpenAPI collection that contain multiple keys. The fix ensures that all API keys are correctly included during the import process.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.