Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify origin country per-method call #37

Open
gf3 opened this issue Jan 28, 2021 · 5 comments
Open

Specify origin country per-method call #37

gf3 opened this issue Jan 28, 2021 · 5 comments
Assignees

Comments

@gf3
Copy link

gf3 commented Jan 28, 2021

Hi there,

Thanks for building this wonderfully useful library. We're planning on using this in our e-commerce platform which allows users in several different countries to sell to their customers. This means we'll need to change the origin country on a per-estimate/invoice basis. Using a global origin introduces a race condition under our circumstances, i.e. when two customers from two different user's origins request an estimate/invoice at the same time.

Are there any plans to allow the origin to be set at the time the sales tax is requested? Thanks!

@valeriansaliou
Copy link
Owner

Hello! Thanks for the feedback. I'm leaving this open as I 100% understand this is a recurring need for Marketplace-type businesses, whereas ours (Crisp, for which this library was initially built), is a SaaS.

I'll probably provide a way to consume the library by creating independent instances of it.

@gf3
Copy link
Author

gf3 commented Jan 28, 2021

That sounds like a perfect solution. Thank you!

@holm
Copy link

holm commented Mar 7, 2021

This would be amazing.

Thanks for a very cool library, that I wish I had found earlier :)

@valentindoulcier
Copy link

Hi @valeriansaliou,
Is there any news regarding this issue?
Thank's!

@valeriansaliou
Copy link
Owner

I'm open to PRs on that. No bandwidth to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants