Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issues]: implement function "split_from_end" - 7 points #588

Open
Michaelg22 opened this issue Apr 3, 2023 · 5 comments
Open
Assignees
Labels

Comments

@Michaelg22
Copy link
Contributor

Motivation

Vanus Functions are a series of pre-built functions worked within Vanus transformer. By choosing a function, users can specify the way that events will be changed.

It will be a good start if you decide to contribute to Vanus codes.

Details

Function name: split_from_end

Args

  • sourceJsonPath
  • position
  • targetJsonPath

Description

The function is used to scan the source JSON path from right to left, split it into an array of two sub-strings from the given numeric position of the character, and assign the array to a target JSON path. The character of the position should be included in the first sub-string (from right to left).

Example

{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data": {
        "appinfoA" : "hello world!"
       

    }
}

After the function.

"pipeline":[
    {"command":["split_from_end", "$.data.appinfoA", 5, "$.data. appinfoB"]}
]

The transformed event should look like this:

{
    "specversion" : "1.0",
    "type" : "com.example.someevent",
    "source" : "/mycontext",
    "subject": null,
    "id" : "C234-1234-1234",
    "time" : "2018-04-05T17:31:00Z",
    "comexampleextension1" : "value",
    "comexampleothervalue" : 5,
    "datacontenttype" : "application/json",
    "data" : {
        "appinfoA" : "hello world!",
         "appinfoB" : ["hello w", "orld!"]
   }
}

How to implement

  1. Fork the vanus repository.
  2. Create a branch function-split_from_end
  3. Create split_from_end.go under internal/primitive/transform/action/strings, and then implement the function.
  4. Create split_from_end_test.go under internal/primitive/transform/action/strings for unit test.
  5. Register your function in internal/primitive/transform/runtime/init.go.
  6. Submit your PR

Contribution points

Each issue counts specific points based on its difficulty. Contributors earn the corresponding points if they solve that issue. Contribution points are used to describe the contributions contributors have made. They can also be used to get rewards when there are community events.

This issue counts 7 points.

How to claim to solve the issue

If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.

Vanus community will assign the issue to you on time.

@allensuvorov
Copy link
Contributor

Team, let me know if I can be of help for this one. I did split from start.

@ShadowWalker98
Copy link

I'd like to implement this function, please assign this issue to me.

@Michaelg22
Copy link
Contributor Author

Hi @ShadowWalker98 thank you for your interest, I assigned it to you

@arsenalzp
Copy link

Hello,
Any progress with this issue since April?

@ShadowWalker98
Copy link

ShadowWalker98 commented Dec 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants