Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile webview taps on the chart doesn't display tooltips properly since vega version 5.26.0 #3893

Open
6 tasks done
ZhaohuaZeng-at opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
bug For bugs or other software errors

Comments

@ZhaohuaZeng-at
Copy link

Please:

  • Check for duplicate issues. Please file separate requests as separate issues on GitHub.
  • Describe how to reproduce the bug.
  • Use the latest Vega version, if possible. Always indicate which version you are using.
  • If you are using Kibana, first read the instructions for posting Kibana Vega issues.
  • Include error messages or gifs/screenshots of problematic behavior, if applicable.
  • Provide an example specification and accessible data. Try to provide the simplest specification that reproduces the problem. To share a specification, use the Vega-Editor and click "Share" to embed a working link, or provide an example spec in JSON, wrapped by triple backticks like this:

Hi there, I think there is a bug introduced in 5.26.0 that makes tooltips not show up on tap on a mobile device.

I have reproduced this in CodeSandbox by simply swapping those two versions on the file.

To reproduce the issue, you can simply switch to mobile view on chrome browser via the developer tools, to simulate mobile taps. And then you can see that in 5.26.0 version of vega, tap on a bar in the bar chart doesn't display tooltip, and you have to keep on touching the bar to keep it on screen. However, in 5.25.0, once there is tap on a bar, the tooltip will keep on displaying.

Example videos:

in 5.25.0 (expected):

expected.mov

in 5.26.0 (bug):

bug.mov

@ZhaohuaZeng-at ZhaohuaZeng-at added the bug For bugs or other software errors label Mar 14, 2024
@ZhaohuaZeng-at ZhaohuaZeng-at changed the title Mobile webview tap on the chart doesn't display tooltips properly since vega version 5.26.0 Mobile webview taps on the chart doesn't display tooltips properly since vega version 5.26.0 Mar 14, 2024
@domoritz
Copy link
Member

Is this related to #3781?

@kadamwhite
Copy link
Contributor

kadamwhite commented Apr 23, 2024

Is this related to #3781?

@domoritz I believe so, yes. I've been looking into the pointer events, as you suggested in slack: this codepen shows the sequence of PointerOut and PointerMove events when you execute a tap and drag action. In my testing a pointerout event appears to fire immediately at the end of every PointerMove sequence, where mouseout by contrast would fire later on, or on a subsequent tap.

pointerout mobile behavior

My guess is that this behavior is causing the tooltip to be hidden as soon as it is shown, which we can observe by viewing the mutations in the document element inspector:

tooltip pointerout vega behavior

lsh pushed a commit that referenced this issue Apr 26, 2024
Alternative approach to #3907, which selectively reverts only one line
from #3781 in order to mitigate #3893.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For bugs or other software errors
Projects
None yet
Development

No branches or pull requests

4 participants