Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Satori cannot render svg data URI with comma inside #597

Open
kiwiyou opened this issue Mar 5, 2024 · 0 comments · May be fixed by #596
Open

Satori cannot render svg data URI with comma inside #597

kiwiyou opened this issue Mar 5, 2024 · 0 comments · May be fixed by #596

Comments

@kiwiyou
Copy link

kiwiyou commented Mar 5, 2024

Bug report

Description / Observed Behavior

If charset is specified, satori cannot render svg data URI that contains , (comma).

svg in data URI with charset set and comma inside errors

Expected Behavior

satori successfully renders the svg.

svg in data URI with charset set and comma inside renders well

Reproduction

https://og-playground.vercel.app/?share=bZDLboQwDEV_BbnLUghtR4IUWFTqH3TJYniEkDYQRMyEEeLf69DtREqU63v8kHdoTSeAQ65GGdilLfZrV2PN1VhLEdubfN5G_dEO9WIFFiv2L2mYUzig8GSLCgbEmcexcy5yb5FZZPzKGPOZFfxDfNNq-n2IJlmWxadN8E0sVpmJwCRKvFbCfZqNNAtYkLDzVlDms9F3aaagV1qT-9SfhzJmoyb0Q11YeNJhegn8Q15c5n6o8nrQF0IwM1IzC3wHpzocgKfEwyCUHBD4uxedaFYJvK-1FSGI0fyo7_vs14XuVFSnNxN-jY3ogOOyiiMErBsiBqG1cWbRHRx_

Additional Context

Satori version, and any other context about the problem here.

It seems that data URI parsing is based on incorrect regex.
Original Specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect data URL parsing kiwiyou/satori
1 participant
@kiwiyou